resource/cloudflare_page_rule: Remove HasChange for edge_cache_ttl
#453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to swapping to PUT requests for updating page rules, we used to perform manual diff checks that would determine which actions we would add to the page rule before sending it. This is no longer now as we swapped to using a PUT request which replaces the whole rule and we are able to send the whole page rule as-is without doing the work ourselves. This popped up as it's caused a bug whereby updating a page rule that includes a `edge_cache_ttl` (but not change it) results in the `edge_cache_ttl` being dropped completely. `TestAccCloudflarePageRuleEdgeCacheTTLNotClobbered` is the regression test case that demonstrates the behaviour.
ghost
added
the
patryk
approved these changes
Aug 22, 2019
patryk
added
kind/bug
boekkooi-lengoo
pushed a commit
to boekkooi-lengoo/terraform-provider-cloudflare
that referenced
this pull request
Feb 28, 2022
Co-authored-by: Callum Loh <cloh@squiz.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to swapping to PUT requests for updating page rules, we used to
perform manual diff checks that would determine which actions we would
add to the page rule before sending it. This is no longer now as we
swapped to using a PUT request which replaces the whole rule and we are
able to send the whole page rule as-is without doing the work ourselves.
This popped up as it's caused a bug whereby updating a page rule that
includes a
edge_cache_ttl(but not change it) results in theedge_cache_ttlbeing dropped completely.TestAccCloudflarePageRuleEdgeCacheTTLNotClobberedis the regressiontest case that demonstrates the behaviour.