Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add data source for WAF Groups #508

Merged
merged 2 commits into from
Oct 15, 2019

Conversation

xaf
Copy link

@xaf xaf commented Oct 9, 2019

No description provided.

@ghost ghost added size/XL kind/documentation Categorizes issue or PR as related to documentation. labels Oct 9, 2019
@jacobbednarz
Copy link
Member

Are you able to provide a description of what the use case is for this? I can't think of any and would like to make sure we have a use case before just adding these new datasources.

@xaf
Copy link
Author

xaf commented Oct 9, 2019

We want to be able to use the values returned by those data sources to use for_each on a resource element after and run bulk options for "most of" the groups/packages (for the other PR). It allows to make sure our infrastructure "defaults to" some setting for the things that we haven't set manually otherwise.

For instance, something like:

resource "cloudflare_waf_group" "bulk" {
  for_each = {
    for _, group in data.cloudflare_waf_groups.selected_bulk.groups :
    group['id'] => group
    if group['id'] != xxxx // If I want to exclude this one here because I did a singular action on it
  }

  zone_id = data.cloudflare_waf_groups.selected_bulk.zone_id
  group_id = each.key
  package_id = each.value['package_id']
  mode = "off"
}

cc @sbfaulkner

Copy link

@patryk patryk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xaf
Copy link
Author

xaf commented Oct 11, 2019

@xaf xaf requested a review from patryk October 11, 2019 17:24
@patryk patryk merged commit 8aeb948 into cloudflare:master Oct 15, 2019
@patryk
Copy link

patryk commented Oct 15, 2019

Thanks!

@xaf
Copy link
Author

xaf commented Oct 15, 2019

Thank you! :)

@xaf xaf deleted the xaf/add_data_source_waf_groups branch October 15, 2019 17:23
boekkooi-lengoo pushed a commit to boekkooi-lengoo/terraform-provider-cloudflare that referenced this pull request Feb 28, 2022
* Add support for TLS certificate packs

Updates the library to introduce support for certificate packs.

API documentation:

- https://api.cloudflare.com/#certificate-packs-properties
- https://developers.cloudflare.com/ssl/advanced-certificate-manager

* simplify response structs

Co-authored-by: Patryk Szczygłowski <patryk@patryk.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/documentation Categorizes issue or PR as related to documentation. size/XL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants