Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add data source for WAF Rules #525

Merged

Conversation

XaF
Copy link
Contributor

@XaF XaF commented Oct 24, 2019

Following up on #506 and #508, and as explained in comment https://github.com/terraform-providers/terraform-provider-cloudflare/pull/508#issuecomment-540235472, we need to be able to bulk enable/disable rules too. As the resource already existed I did not pay attention that we also needed to create the data source previously... But realized that missing part while updating our terraform to the last 2.0.1 release!

This thus adds the new data source and related documentation and acceptance tests.

=== RUN   TestAccCloudflareWAFRules_NoFilter
=== PAUSE TestAccCloudflareWAFRules_NoFilter
=== RUN   TestAccCloudflareWAFRules_MatchDescription
=== PAUSE TestAccCloudflareWAFRules_MatchDescription
=== RUN   TestAccCloudflareWAFRules_MatchMode
=== PAUSE TestAccCloudflareWAFRules_MatchMode
=== CONT  TestAccCloudflareWAFRules_NoFilter
=== CONT  TestAccCloudflareWAFRules_MatchMode
=== CONT  TestAccCloudflareWAFRules_MatchDescription
--- PASS: TestAccCloudflareWAFRules_MatchMode (6.40s)
--- PASS: TestAccCloudflareWAFRules_NoFilter (6.66s)
--- PASS: TestAccCloudflareWAFRules_MatchDescription (6.69s)
PASS
ok  	github.com/terraform-providers/terraform-provider-cloudflare/cloudflare	6.720s

@ghost ghost added size/XL kind/documentation Categorizes issue or PR as related to documentation. labels Oct 24, 2019
XaF and others added 3 commits October 28, 2019 19:02
Co-Authored-By: Jacob Bednarz <jacob.bednarz@gmail.com>
Co-Authored-By: Jacob Bednarz <jacob.bednarz@gmail.com>
@jacobbednarz jacobbednarz merged commit 66cfb4f into cloudflare:master Nov 3, 2019
@XaF XaF deleted the xaf/add_data_source_waf_rules branch November 6, 2019 22:25
boekkooi-lengoo pushed a commit to boekkooi-lengoo/terraform-provider-cloudflare that referenced this pull request Feb 28, 2022
…rg-x-net-digest

Update golang.org/x/net commit hash to 62affa3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/documentation Categorizes issue or PR as related to documentation. size/XL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants