Implement Origin CA certificate resource #547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
size/XL
kind/documentation
|
I've bumped the |
|
Yep will do! I'll have to wait on cloudflare/cloudflare-go#392 first |
player-two
force-pushed
the
origin-ca-certificate-resource
branch
2 times, most recently
from
905d653 to
990beb6
Compare
|
That last commit will have to change, either with a legit version number once the library is bumped or removed entirely if dependencies should be handled in a separate PR. I just added it for now to see if CI would pass. |
|
@player-two you should be able to remove the last commit and just wait on the version bump. We'll merge it once it's landed in cloudflare-go. |
player-two
force-pushed
the
origin-ca-certificate-resource
branch
from
990beb6 to
36eb69a
Compare
player-two
force-pushed
the
origin-ca-certificate-resource
branch
from
36eb69a to
3bef2b1
Compare
boekkooi-lengoo
pushed a commit
to boekkooi-lengoo/terraform-provider-cloudflare
that referenced
this pull request
Feb 28, 2022
…re#547) This will ensure that `PerformTraceroute` works without an explicit colocation list passed to it as documented in the API docs. Fixes cloudflare#546
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #433
Depends on cloudflare/cloudflare-go#387
Before the sdk pr is merged, this can only be tested via
I'm not terribly confident about the
api_user_service_key- is there ever a case where it would be set to something other than the Origin CA key? If so, I think we'd need a way to save both and have this resource's methods create a new client.