Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ip6 as valid type for access rules #560

Merged
merged 1 commit into from
Dec 17, 2019

Conversation

Evesy
Copy link

@Evesy Evesy commented Dec 16, 2019

It's not yet in the API docs (Which I've raised with CF), a valid type option for Access Rules is ip6 for IPv6 addresses.

Currently if you use type ip with an IPv6 address your rule is successfully created, however subsequent TF plans will try to change the resource:

-/+ resource "cloudflare_access_rule" "example" {
      ~ configuration = { # forces replacement
          ~ "target" = "ip6" -> "ip"
          ~ "value"  = "2604:a880:0800:00a1:0000:0000:171e:5001" -> "2604:a880:800:a1::171e:5001"
        }
      ~ id            = "e5860588ab3b4a598c86da69676017ad" -> (known after apply)
        mode          = "block"
        notes         = "Block"
        zone_id       = "123abc456def"
    }

If you require any tests let me know, wasn't sure if it was necessary for a change to the allowed inputs (Only one type is currently tested anyway)

@ghost ghost added size/XS kind/documentation Categorizes issue or PR as related to documentation. labels Dec 16, 2019
@jacobbednarz
Copy link
Member

Are you able to raise a support ticket with Cloudflare to get this updated in the documentation? We generally don’t like adding functionality or options that aren’t publicly documented.

@Evesy
Copy link
Author

Evesy commented Dec 17, 2019

I have an open ticket with support, will post back when there's an update

@jacobbednarz
Copy link
Member

Awesome, thank you! Happy to land this as long as it's in the works.

(Please do update this when it's added though!)

@jacobbednarz jacobbednarz merged commit 3fbf01e into cloudflare:master Dec 17, 2019
boekkooi-lengoo pushed a commit to boekkooi-lengoo/terraform-provider-cloudflare that referenced this pull request Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/documentation Categorizes issue or PR as related to documentation. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants