Add support for Access Identity Provider #597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
size/XL
kind/documentation
|
Depends on cloudflare/cloudflare-go#403 and build will be red until that lands. |
jacobbednarz
commented
Feb 12, 2020
| "client_secret": { | ||
| Type: schema.TypeString, | ||
| Optional: true, | ||
| // client_secret is a write only operation from the Cloudflare API |
There was a problem hiding this comment.
I'm still not totally sold on this however it's the most elegant way of managing the write-but-never-retrievable situation the client_secret and idp_public_cert fields are in.
jacobbednarz
commented
Feb 12, 2020
| IDPConfig.Attributes = attrData | ||
| } | ||
|
|
||
| IDPConfig.AppsDomain = d.Get("config.0.apps_domain").(string) |
There was a problem hiding this comment.
Yes, this is a little verbose but I don't mind it as it's explicit and it doesn't require confusing reflection to work out what each field should be.
jacobbednarz
force-pushed
the
access-identity-provider-support
branch
from
eda5fa8 to
72ca699
Compare
|
Got a couple of integration error failures now that I'll need to checkout |
patryk
requested changes
Feb 27, 2020
jacobbednarz
referenced
this pull request
in jacobbednarz/cloudflare-go
Mar 8, 2020
When the work for terraform-providers/terraform-provider-cloudflare#597 was started, the `messages` object was either empty array or a single string (per the original `cloudflare.Response`[1] struct) but the API response is now spitting out an array of `message` objects inside of the current array. To fix the issue, the two structs have been updated to conform to the required objects. [1]: https://github.com/cloudflare/cloudflare-go/blob/master/cloudflare.go#L363
|
The issue for the two CI failures above have been fixed in cloudflare/cloudflare-go#425 due to the underlying API response changing. Once that is merged, we're 👌 to merge this. |
patryk
referenced
this pull request
in cloudflare/cloudflare-go
Mar 9, 2020
* Update `*ListResponse` structs to match API responses When the work for terraform-providers/terraform-provider-cloudflare#597 was started, the `messages` object was either empty array or a single string (per the original `cloudflare.Response`[1] struct) but the API response is now spitting out an array of `message` objects inside of the current array. To fix the issue, the two structs have been updated to conform to the required objects. [1]: https://github.com/cloudflare/cloudflare-go/blob/master/cloudflare.go#L363 * Use Response shared struct for handling fields Co-authored-by: Patryk Szczygłowski <patryk@patryk.net>
|
Thanks for investigation. It looks that the API has actually been fixed 🙄 |
patryk
approved these changes
Mar 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces full support for Cloudflare Access Identity Providers.
API documentation: https://api.cloudflare.com/#access-identity-providers-properties
Developer documentation: https://developers.cloudflare.com/access/configuring-identity-providers/