Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK-88: Add edge_ips, argo_smart_routing support for Spectrum #631

Merged
merged 3 commits into from
Mar 25, 2020

Conversation

patryk
Copy link
Contributor

@patryk patryk commented Mar 24, 2020

This PR adds the following to Spectrum Application resource:

  • edge_ips - Specifies Edge IPs provisioned with optional Bring Your Own IPs feature
  • argo_smart_routing - Enables Argo Smart Routing for Spectrum application (
    TCP only)
  • edge_ip_connectivity - Specifies IP address family used for edge DNS record for Spectrum Application (IPv4/6, etc.)

@ghost ghost added size/M kind/documentation Categorizes issue or PR as related to documentation. labels Mar 24, 2020
@patryk patryk requested a review from jacobbednarz March 24, 2020 21:00
Copy link
Member

@jacobbednarz jacobbednarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this has busted the Import.

------- Stdout: -------
=== RUN   TestAccCloudflareSpectrumApplication_Import
=== PAUSE TestAccCloudflareSpectrumApplication_Import
=== CONT  TestAccCloudflareSpectrumApplication_Import
--- FAIL: TestAccCloudflareSpectrumApplication_Import (4.51s)
    testing.go:654: Step 1 error: ImportStateVerify attributes not equivalent. Difference is shown below. Top is actual, bottom is expected.
        
        (map[string]string) {
        }
        
        
        (map[string]string) (len=1) {
         (string) (len=20) "edge_ip_connectivity": (string) (len=3) "all"
        }
        
FAIL

@patryk patryk requested a review from jacobbednarz March 25, 2020 14:47
@patryk
Copy link
Contributor Author

patryk commented Mar 25, 2020

@jacobbednarz made some small changes to make test happy.

Copy link
Member

@jacobbednarz jacobbednarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! 🚢

@jacobbednarz jacobbednarz merged commit 9ec5be3 into master Mar 25, 2020
@jacobbednarz jacobbednarz deleted the SDK-88 branch March 25, 2020 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/documentation Categorizes issue or PR as related to documentation. size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants