Add support for external Access Groups #633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a static IdP which has been manually setup to support testing the Access Group integrations. This commit ensures we don't automatically remove it.
Updates the `cloudflare_access_policy` to support defining external integrations for the Access Policy. Closes cloudflare#628
ghost
added
the
kind/documentation
I was silly and duplicated this for no reason. This can just use the same method now.
jacobbednarz
commented
Mar 25, 2020
| CommonName string `json:"common_name"` | ||
| }{CommonName: values.(string)}}) | ||
| } | ||
| } else if accessGroupType == "gsuite" { |
There was a problem hiding this comment.
This is quite the mess. I'm going to look at cleaning this giant block of conditionals up in another PR.
Because this needs to be consistently available, it's super hard to get right with automation. Let's remove it for now until we have a better option.
jacobbednarz
force-pushed
the
access-group-support
branch
from
a55dd2a to
4865352
Compare
boekkooi-lengoo
pushed a commit
to boekkooi-lengoo/terraform-provider-cloudflare
that referenced
this pull request
Feb 28, 2022
…ctions/actions/checkout-2.3.4 build(deps): bump actions/checkout from 2 to 2.3.4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the
cloudflare_access_policyto support defining externalintegrations for the Access Policy.
Closes #628