new resource: WAF overrides #691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows reuse of the scaffolding used to build a WAF override without duplicating the iterations and formatting in multiple places.
This single scenario allows us to test all three cases without adding 3 more tests 🎉
ghost
added
size/XL
kind/documentation
jacobbednarz
commented
May 20, 2020
| // buildWAFOverride centralises the creation of a WAFOverride struct which can | ||
| // be reused between Create and Update methods to ensure consistent building of | ||
| // the values. | ||
| func buildWAFOverride(d *schema.ResourceData) (cloudflare.WAFOverride, error) { |
There was a problem hiding this comment.
We don't yet emit error anywhere in here but I'd rather return it now and have it already accounted for then try to introduce a breaking change later on.
boekkooi-lengoo
pushed a commit
to boekkooi-lengoo/terraform-provider-cloudflare
that referenced
this pull request
Feb 28, 2022
test(zone): refactor testing of zone.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support and documentation for configuring WAF overrides via a new resource
cloudflare_waf_override.Documentation: https://api.cloudflare.com/#waf-overrides-properties
Screenshots
Sidebar
Full page
Closes #554