ForceNew if zone changes on CustomHostname resource

[cdloh]

Custom Hostnames cannot be moved across zones. ForceNew if the zone changes.

[jacobbednarz]

Thanks for this one @cdloh! Can you please add a test exercising this new condition?

terraform-provider-cloudflare/cloudflare/resource_cloudflare_custom_hostname_test.go

Lines 188 to 224 in f61f3ad

	func TestAccCloudflareCustomHostnameUpdate(t *testing.T) {
	t.Parallel()
	zoneID := os.Getenv("CLOUDFLARE_ZONE_ID")
	domain := os.Getenv("CLOUDFLARE_DOMAIN")
	rnd := generateRandomResourceName()
	resourceName := "cloudflare_custom_hostname." + rnd
	resource.Test(t, resource.TestCase{
	PreCheck: func() { testAccPreCheck(t) },
	Providers: testAccProviders,
	Steps: []resource.TestStep{
	{
	Config: testAccCheckCloudflareCustomHostnameWithCustomSSLSettings(zoneID, rnd, domain),
	Check: resource.ComposeTestCheckFunc(
	resource.TestCheckResourceAttr(resourceName, "zone_id", zoneID),
	resource.TestCheckResourceAttr(resourceName, "hostname", fmt.Sprintf("%s.%s", rnd, domain)),
	resource.TestCheckResourceAttr(resourceName, "ssl.0.settings.0.http2", "off"),
	resource.TestCheckResourceAttr(resourceName, "ssl.0.settings.0.min_tls_version", "1.2"),
	resource.TestCheckResourceAttr(resourceName, "ssl.0.settings.0.ciphers.#", "2"),
	resource.TestCheckResourceAttr(resourceName, "ssl.0.settings.0.ciphers.0", "ECDHE-RSA-AES128-GCM-SHA256"),
	resource.TestCheckResourceAttr(resourceName, "ssl.0.settings.0.ciphers.1", "AES128-SHA"),
	),
	},
	{
	Config: testAccCheckCloudflareCustomHostnameWithCustomSSLSettingsUpdated(zoneID, rnd, domain),
	Check: resource.ComposeTestCheckFunc(
	resource.TestCheckResourceAttr(resourceName, "zone_id", zoneID),
	resource.TestCheckResourceAttr(resourceName, "hostname", fmt.Sprintf("%s.%s", rnd, domain)),
	resource.TestCheckResourceAttr(resourceName, "ssl.0.settings.0.http2", "off"),
	resource.TestCheckResourceAttr(resourceName, "ssl.0.settings.0.min_tls_version", "1.1"),
	resource.TestCheckResourceAttr(resourceName, "ssl.0.settings.0.ciphers.#", "2"),
	resource.TestCheckResourceAttr(resourceName, "ssl.0.settings.0.ciphers.0", "ECDHE-RSA-AES128-GCM-SHA256"),
	resource.TestCheckResourceAttr(resourceName, "ssl.0.settings.0.ciphers.1", "AES128-SHA"),
	),
	},
	},
	})
	}

is an example of where we do this elsewhere and confirm the values are indeed changing and Terraform is doing the expected thing.

[cdloh]

@jacobbednarz is there another zoneid within the environment to test with? If there isn't another zone I'm unsure how to test it moving across zones.

[jacobbednarz]

Yep, use CLOUDFLARE_ALT_ZONE_ID and confirm the plan isn't empty.