resource/custom_hostname: Ensure Import stores hostname
#788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Within the `Read` function, we weren't setting the hostname to the imported value (assuming it was always provided) which has left it missing in state and subsequently causing replacements unnecessarily. Fixes cloudflare#783
jacobbednarz
commented
Sep 6, 2020
| ImportStateIdPrefix: fmt.Sprintf("%s/", zoneID), | ||
| ImportState: true, | ||
| ImportStateVerify: true, | ||
| ImportStateVerifyIgnore: []string{"ssl.#", "ssl.0.certificate_authority", "ssl.0.cname_name", "ssl.0.cname_target", "ssl.0.custom_certificate", "ssl.0.custom_key", "ssl.0.method", "ssl.0.status", "ssl.0.type", "ssl.0.wildcard"}, |
There was a problem hiding this comment.
As we're not providing these in the resource, the ImportStateVerify will always fail. Remove them from the check and just assert on the values we know we have.
patryk
approved these changes
Sep 7, 2020
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Within the
Readfunction, we weren't setting the hostname to theimported value (assuming it was always provided) which has left it
missing in state and subsequently causing replacements unnecessarily.
Fixes #783