resource/ip_list: Remove item.id from schema
#796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Despite the `item` ID being marked as Computed, it is showing unnecessary changes when running `apply` without any changes. For whatever reason, the ID being returned is changing and Terraform is trying to keep it in sync. As we aren't using it, let's get rid of it and avoid the hassle of keeping it in sync.
|
@cehrig When this was added, was there any particular reason the item ID was required? Are we 👌 to do away with it? |
|
Yeap, it's OK to remove it atm. since the resource is replacing the current list when making any changes to the items. That very likely is the reason why Item IDs are changing. If I find some time, I'll try to find a way to explicitly remove / add / update items by their ID. When I initially created the resource there were some very strange ordering side effect when working on the Item IDs, so I decided to go the full-replace route. |
|
Awesome, thanks for the confirmation. We can always add it back in if we have a way of updating the list items without replacing the entire list. |
jacobbednarz
changed the title
item.id from schemaitem.id from schema
boekkooi-lengoo
pushed a commit
to boekkooi-lengoo/terraform-provider-cloudflare
that referenced
this pull request
Feb 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Despite the
itemID being marked as Computed, it is showingunnecessary changes when running
applywithout any changes. Forwhatever reason, the ID being returned is changing and Terraform is
trying to keep it in sync.
As we aren't using it, let's get rid of it and avoid the hassle of
keeping it in sync.