Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Off by 1 bug in resource_cloudflare_authenticated_origin_pulls_* importing #858

Closed
dhaynespls opened this issue Nov 4, 2020 · 6 comments · Fixed by #859
Closed

Off by 1 bug in resource_cloudflare_authenticated_origin_pulls_* importing #858

dhaynespls opened this issue Nov 4, 2020 · 6 comments · Fixed by #859
Assignees
Labels
good first issue kind/bug Categorizes issue or PR as related to a bug. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@dhaynespls
Copy link

These should be the number 3 as len() is not zero-indexed.

@jacobbednarz jacobbednarz added good first issue kind/bug Categorizes issue or PR as related to a bug. triage/accepted Indicates an issue or PR is ready to be actively worked on. labels Nov 4, 2020
@jacobbednarz
Copy link
Member

Thanks for catching this one @dhaynespls 👏 Are you able to going to PR a fix for this one? If not, I can knock something together given the size of the fix.

@dhaynespls
Copy link
Author

@jacobbednarz PR is incoming, though I'd appreciate if we'd be able to roll it into a point release sometime soon if there's other things that are ready to go

@jacobbednarz
Copy link
Member

We've got a couple of unreleased bug fixes and a new resource we can chuck into a new release if this is needed to be expedited.

@dhaynespls
Copy link
Author

Up to y'all if it's not too much work! From my end, I can sit on this as a blocker until next week.

@jacobbednarz
Copy link
Member

jacobbednarz commented Nov 4, 2020

@jacobbednarz
Copy link
Member

v2.13.0 is in the pipeline now; should land in the registry within the next hour or so (the sync is on the Hashicorp side).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue kind/bug Categorizes issue or PR as related to a bug. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants