Revert schema based filter validation #863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to the endpoint not supporting API tokens, we needed to build a standalone client which hasn't worked out well and the workarounds to fix it are against the grain of how the Terraform schema is intended to be used leaving us in situation where change in upstream functionality may force us to be on an older version of the SDK if we were to continue. Instead, this reverts cloudflare#848 and cloudflare#860 and once API token support is added to the endpoint, we can reintroduce this without a standalone client. Closes cloudflare#861
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the endpoint not supporting API tokens, we needed to build a
standalone client which hasn't worked out well and the workarounds to
fix it are against the grain of how the Terraform schema is intended to
be used leaving us in situation where change in upstream functionality
may force us to be on an older version of the SDK if we were to
continue. Instead, this reverts #848 and #860 and once API token support
is added to the endpoint, we can reintroduce this without a standalone
client.
Closes #861