cloudflare_page_rule: handle lists and string values for cache_key_fields
#975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ields`
The page rule API for defining cache keys allows you to include/exclude
either a list or all of the query parameters. However, to apply the
changes to all, the value sent must be a string, not a list as we've
previously sent (due to reusing `[]interface{}{"*"}`). In the case of
sending `exclude = ["*"]` it excludes the "*" parameter from the
cache key, not all of the possible keys.
Closes #967
jacobbednarz
force-pushed
the
handle-cache-key-fields-all-options
branch
from
ab7b841 to
a8a428a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The page rule API for defining cache keys allows you to include/exclude
either a list or all of the query parameters. However, to apply the
changes to all, the value sent must be a string, not a list as we've
previously sent (due to reusing
[]interface{}{"*"}). In the case ofsending
exclude = ["*"]it excludes the "*" parameter from thecache key, not all of the possible keys.
Closes #967