cloudflare_record: check record.Priority using the API, not the schema
#992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobbednarz
force-pushed
the
use-api-nil-check-instead-of-schema
branch
from
f198158 to
fc77add
Compare
Following on from the changes in 2.19.0 (and 2.19.1 to actually ship the change), a regression was introduced that is inadvertantly causing a panic due to the `d.GetOkExists` failing to accurately determine when to apply the `record.Priority` value to the state. `d.GetOkExists` is documented as: > GetOkExists can check if TypeBool attributes that are Optional with > no Default value have been set. While the value isn't a bool, it acts similarly as 0 in this context is both a valid value and a zero value for the field. To combat the panic, I've swapped the check to instead compare the value provided by the API to determine whether or not we want to set it. This approach wasn't initially taken as the API used to return 0 in all cases where the value wasn't explicitly set and the underlying library would ignore it. Hopefully, with MX records allowing 0, this is no longer an issue going forward. Closes #988
jacobbednarz
force-pushed
the
use-api-nil-check-instead-of-schema
branch
from
fc77add to
5daf453
Compare
|
Worked for our repository. Crashed with |
|
Thank you @Ka1wa! Just for posterity, could you post what record type and it's configuration in case down the track we dig further into the cause? |
|
I saw the same issue with only A records and no priority set on that block. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following on from the changes in 2.19.0 (and 2.19.1 to actually ship the
change), a regression was introduced that is inadvertantly causing a
panic due to the
d.GetOkExistsfailing to accurately determine when toapply the
record.Priorityvalue to the state.d.GetOkExistsis documented as:While the value isn't a bool, it acts similarly as 0 in this context is
both a valid value and a zero value for the field.
To combat the panic, I've swapped the check to instead compare the value
provided by the API to determine whether or not we want to set it. This
approach wasn't initially taken as the API used to return 0 in all cases
where the value wasn't explicitly set and the underlying library would
ignore it. Hopefully, with MX records allowing 0, this is no longer an
issue going forward.
Closes #988