Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 BUG: Unbound workers don’t respect subrequest limit in --local mode #1601

Closed
huw opened this issue Aug 2, 2022 · 1 comment · Fixed by #1602
Closed

🐛 BUG: Unbound workers don’t respect subrequest limit in --local mode #1601

huw opened this issue Aug 2, 2022 · 1 comment · Fixed by #1602
Assignees
Labels
bug Something that isn't working

Comments

@huw
Copy link
Contributor

huw commented Aug 2, 2022

What version of Wrangler are you using?

2.0.24

What operating system are you using?

Linux

Describe the Bug

Miniflare recently updated to support new subrequest limits for Unbound workers (cloudflare/miniflare#274), but it requires the caller to pass usageModel. In --local mode, wrangler dev doesn’t support the new subrequest limits because it’s not passing the parameter.

I tested this locally, and passing unbound to the compiled Miniflare CLI results in the correct behaviour.

I’ll put together a PR to read this from wrangler.toml and pass it through.

@huw huw added the bug Something that isn't working label Aug 2, 2022
@JacobMGEvans JacobMGEvans self-assigned this Aug 2, 2022
@JacobMGEvans
Copy link
Contributor

Appreciate the work!! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something that isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants