Skip to content
This repository has been archived by the owner on Aug 3, 2023. It is now read-only.

Allow specifying preview host as option to preview command #351

Closed
xortive opened this issue Jul 23, 2019 · 5 comments
Closed

Allow specifying preview host as option to preview command #351

xortive opened this issue Jul 23, 2019 · 5 comments
Labels
design feature Feature requests and suggestions
Milestone

Comments

@xortive
Copy link
Contributor

xortive commented Jul 23, 2019

Currently the preview host is hardcoded to example.com. We should allow people to configure it when running wrangler preview so they don't have to change it in the UI after the preview window opens.

@xortive xortive added feature Feature requests and suggestions status - PR welcome labels Jul 23, 2019
@steveklabnik
Copy link
Contributor

I wonder if we can't use the route for this...

@EverlastingBugstopper
Copy link
Contributor

+1 on making this configurable

@steveklabnik this is something we ran into when implementing http events in our serverless framework. It's a little wonky because routes have wildcards - and there may be multiple endpoints (and multiple headers) you want to test with for a given worker. Defaulting to something that triggers the route would be good but I think we should also allow the user to pass in at least a url, if not also the method + headers.

@rochapablo
Copy link

any update?

@EverlastingBugstopper
Copy link
Contributor

@rochapablo you can follow along with this pull request #1001 and also keep an eye out for an alpha release of wrangler dev.

@EverlastingBugstopper
Copy link
Contributor

solved by #1001

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
design feature Feature requests and suggestions
Projects
None yet
Development

No branches or pull requests

5 participants