This repository has been archived by the owner on Aug 3, 2023. It is now read-only.
Use stdin instead of arguments for wrangler config #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i think this is headed in the right direction- how can i help it get across the finish line? |
|
I was stuck on the tests, If that looks good to you I can continue. |
|
@xtuc sorry for the delayed response- let's definitely finish this up |
ashleygwilliams
changed the title
|
Currently the tests are missing, they should open a |
xtuc
force-pushed
the
refactor-config-stdin
branch
from
0a85d50 to
ac1280b
Compare
xtuc
force-pushed
the
refactor-config-stdin
branch
2 times, most recently
from
c66dcf2 to
9cffd42
Compare
xtuc
changed the title
xtuc
force-pushed
the
refactor-config-stdin
branch
from
9cffd42 to
b313e47
Compare
xtuc
force-pushed
the
refactor-config-stdin
branch
from
b313e47 to
d25d65b
Compare
EverlastingBugstopper
changed the title
EverlastingBugstopper
changed the title
xtuc
force-pushed
the
refactor-config-stdin
branch
7 times, most recently
from
20d9e75 to
cc7782a
Compare
xtuc
force-pushed
the
refactor-config-stdin
branch
from
efb6953 to
cd52965
Compare
xortive
reviewed
Jul 10, 2019
| @@ -1,5 +1,8 @@ | |||
| #![allow(clippy::redundant_closure)] | |||
|
|
|||
| #[macro_use] | |||
| extern crate text_io; | |||
There was a problem hiding this comment.
Nitpick: you can get rid of this extern crate + macro use and just do a ‘use text_io::read’
There was a problem hiding this comment.
text_io only exposes macros and if I use text_io::read! it cannot find macro try_read! in this scope.
ashleygwilliams
added
status - changes requested
regression
xtuc
force-pushed
the
refactor-config-stdin
branch
from
cd52965 to
f0f130d
Compare
This changes the way `wrangler config` works, previously both the email and the api_key were passed as arguments which would be captured by the terminal history. When launching the command it will prompt for an email, once stdin receive a line it will prompt for the api_key. Both lines are values and will be stored in the config. Introduce a `WRANGLER_HOME` environment variable that will configure where Wrangler defines its home directory. It will contain a `config` directory.
xtuc
force-pushed
the
refactor-config-stdin
branch
from
f0f130d to
0054bf9
Compare
This changes the way `wrangler config` works, previously both the email and the api_key were passed as arguments which would be captured by the terminal history. When launching the command it will prompt for an email, once stdin receive a line it will prompt for the api_key. Both lines are values and will be stored in the config.
Avoid the global user config to be system readable, restrict any access to the current user (600). Extends the global_config API to allow to specify a configuration directory to create the configuration file, it's needed for testing.
| @@ -42,3 +45,15 @@ fn get_global_config() -> Result<GlobalUser, failure::Error> { | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| pub fn get_global_config_dir() -> Result<PathBuf, failure::Error> { | |||
| let home_dir = if let Ok(value) = env::var("WRANGLER_HOME") { | |||
There was a problem hiding this comment.
do we (want to) indicate use of this env var in any of our documentation?
There was a problem hiding this comment.
Currently it's undocumented, once this lands we can create an issue. Using XDG standarts (#221) might changes how it works.
ashleygwilliams
approved these changes
Jul 29, 2019
Change global config perm
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the way
wrangler configworks, previously both the emailand the api_key were passed as arguments which would be captured by the
terminal history.
When launching the command it will prompt for an email, once stdin
receive a line it will prompt for the api_key. Both lines are values and
will be stored in the config.
Introduce a
WRANGLER_HOMEenvironment variable that will configurewhere Wrangler defines its home directory. It will contain a
configdirectory.