This repository has been archived by the owner on Aug 3, 2023. It is now read-only.
Change global config perm #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xtuc
commented
Jul 1, 2019
cwndrws
reviewed
Jul 1, 2019
xtuc
force-pushed
the
feat-change-global-config-perms
branch
from
8e6fea7 to
22c2ba5
Compare
xtuc
force-pushed
the
feat-change-global-config-perms
branch
3 times, most recently
from
2dfae76 to
529d445
Compare
xtuc
commented
Jul 2, 2019
|
|
||
| // check dir permissions (but not on windows) | ||
| if !cfg!(target_os = "windows") { | ||
| let mut command = Command::new("stat"); |
There was a problem hiding this comment.
let metadata = config_file.clone().metadata().unwrap();
let permissions = metadata.permissions();
assert_eq!(permissions.mode(), 0o600);The API returned odd modes, that's why I used stat.
xtuc
added
feature
xtuc
force-pushed
the
refactor-config-stdin
branch
from
b313e47 to
d25d65b
Compare
|
Could you explain a bit more what this is doing? Having a hard time grokking from title + comment. Does this have to do with how wrangler is installed? |
|
sent on gchat. |
cwndrws
reviewed
Jul 2, 2019
| ); | ||
|
|
||
| // check dir permissions (but not on windows) | ||
| if !cfg!(target_os = "windows") { |
There was a problem hiding this comment.
I don't know, cc @steveklabnik @ashleygwilliams do you have an idea?
xtuc
force-pushed
the
refactor-config-stdin
branch
7 times, most recently
from
20d9e75 to
cc7782a
Compare
xtuc
force-pushed
the
refactor-config-stdin
branch
from
cc7782a to
efb6953
Compare
xtuc
force-pushed
the
feat-change-global-config-perms
branch
from
529d445 to
6b566d6
Compare
xtuc
force-pushed
the
refactor-config-stdin
branch
from
efb6953 to
cd52965
Compare
xtuc
force-pushed
the
feat-change-global-config-perms
branch
from
6b566d6 to
057da57
Compare
ashleygwilliams
added
the
regression
xtuc
force-pushed
the
refactor-config-stdin
branch
2 times, most recently
from
f0f130d to
0054bf9
Compare
This changes the way `wrangler config` works, previously both the email and the api_key were passed as arguments which would be captured by the terminal history. When launching the command it will prompt for an email, once stdin receive a line it will prompt for the api_key. Both lines are values and will be stored in the config.
xtuc
force-pushed
the
feat-change-global-config-perms
branch
from
057da57 to
7740667
Compare
Avoid the global user config to be system readable, restrict any access to the current user (600). Extends the global_config API to allow to specify a configuration directory to create the configuration file, it's needed for testing.
xtuc
force-pushed
the
feat-change-global-config-perms
branch
from
7740667 to
6f9af42
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid the global user config to be system readable, restrict any access
to the current user and only in read only (600).
Merge #239 first.