feat: Support KV Namespace Configuration #334
Conversation
ashleymichal
force-pushed
the
feat-kv-config
branch
from
beff971 to
ddb663c
Compare
|
rebased onto master. no merge conflicts |
ashleymichal
force-pushed
the
feat-kv-config
branch
2 times, most recently
from
ddb663c to
34b3e60
Compare
src/settings/project/mod.rs
Outdated
| match &self.kv_namespaces { | ||
| Some(kv) => kv.clone(), | ||
| None => Vec::new(), | ||
| } |
There was a problem hiding this comment.
this can be written
self.kv_namespaces.cloned().unwrap_or_else(Vec::new)There was a problem hiding this comment.
i hope you meant .clone() bc .cloned() gave me many complaints.
There was a problem hiding this comment.
no, i meant cloned: https://doc.rust-lang.org/std/option/enum.Option.html#method.cloned
There was a problem hiding this comment.
cloned goes from Option<&T> to Option<T>. But you already have an Option<T>. clone is right here, and I'm wrong.
Thanks, compiler!
ashleymichal
force-pushed
the
feat-kv-config
branch
5 times, most recently
from
f027158 to
f4a8386
Compare
|
@ashleymichal can you add some details about what this PR is, so that I can document it in the CHANGELOG when it's merged? |
| @@ -143,6 +143,17 @@ There are two types of configuration that `wrangler` uses: global user and per p | |||
| This key is optional if you are using a workers.dev subdomain and is only required for `publish --release`. | |||
| - `webpack_config`: This is the path to the webpack configuration file for your worker. This is optional and | |||
| defaults to `webpack.config.js` | |||
| - `[[kv-namespaces]]`: These specify any [Workers KV](https://workers.cloudflare.com/docs/reference/storage/) namespaces you want to access from | |||
There was a problem hiding this comment.
we should explicitly call out that users are expected to make their namespace in the UI
There was a problem hiding this comment.
added commit for this, also points to docs showing API call.
* use serde renames instead of silencing clippy warning in Binding * derive PartialEq for KvNamespace rather than impl'ing manually * pass &Path instead of PathBuf to get_project_config * unwrap_or_else kv_namespaces instead of matching
ashleymichal
force-pushed
the
feat-kv-config
branch
from
2a1156b to
e68a6aa
Compare
Builds on #329 (merge that first)
Closes #273 #92