Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add a link to create a github issue when there is an error. #275

Merged
merged 1 commit into from
Jan 20, 2022

Conversation

petebacondarwin
Copy link
Contributor

When a (non-yargs) error surfaces to the top level,
we know also show a link to Github to encourage the developer to report an issue.

@changeset-bot
Copy link

changeset-bot bot commented Jan 20, 2022

🦋 Changeset detected

Latest commit: 6b632ae

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
wrangler Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@threepointone
Copy link
Contributor

Please update snapshots!

@JacobMGEvans
Copy link
Contributor

✕ should error if a given binding name is not in the configured kv namespaces (6 ms)

Test failed in CI

@petebacondarwin
Copy link
Contributor Author

Ahah! Of course it failed. It now shows this in the error messages.

@petebacondarwin
Copy link
Contributor Author

Tests - FTW!

@petebacondarwin petebacondarwin force-pushed the error-link-to-gh branch 2 times, most recently from bb4e303 to e90024d Compare January 20, 2022 21:07
When a (non-yargs) error surfaces to the top level,
we know also show a link to Github to encourage the developer to report an issue.
@petebacondarwin petebacondarwin merged commit e9ab55a into cloudflare:main Jan 20, 2022
@petebacondarwin petebacondarwin deleted the error-link-to-gh branch January 20, 2022 21:10
@github-actions github-actions bot mentioned this pull request Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants