fix: generate valid URL route paths for pages on Windows #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: c4762d6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
petebacondarwin
force-pushed
the
path-handling-2
branch
from
2fe6cd4 to
75c764c
Compare
petebacondarwin
changed the title
|
No changeset? Probably deserves one. |
Previously route paths were manipulated by file-system path utilities. On Windows this resulted in URLs that had backslashes, which are invalid for such URLs. Fixes cloudflare#51 Closes cloudflare#235 Closes cloudflare#330 Closes cloudflare#327
petebacondarwin
force-pushed
the
path-handling-2
branch
from
75c764c to
c4762d6
Compare
LOL! I had written one, but I didn't include it in the commit. Fixed. |
threepointone
approved these changes
Feb 1, 2022
|
Thanks @threepointone - I'll let @GregBrimble take a look before landing this. |
GregBrimble
approved these changes
Feb 1, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously route paths were manipulated by file-system path utilities.
On Windows this resulted in URLs that had backslashes, which are invalid for such URLs.
Fixes #51
Closes #235
Closes #330
Closes #327