validate binding names don't conflict #665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: fdcbf3e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.developers.workers.dev/runs/2034567542/npm-package-wrangler-665You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.developers.workers.dev/prs/665/npm-package-wrangler-665Or you can use npx https://prerelease-registry.developers.workers.dev/runs/2034567542/npm-package-wrangler-665 dev path/to/script.js |
caass
force-pushed
the
unique-binding-names
branch
2 times, most recently
from
631289c to
0b55698
Compare
added 8 commits
March 23, 2022 13:27
So...a bunch of tests started failing after I rebased. Turns out, we maybe can't trust the inputs to `validateBindingsHaveUniqueNames` to be valid since we don't actually _throw_ until we've performed every config validation. So that means by the time we get to `validateBindingsHaveUniqueNames`, we might have some invalid stuff in the `Config` and we can't really trust the types. :( So I've just gone back to using `getBindingNames` to get the binding names, since it does all the null & type checking necessary to get the binding names out from a binding.
caass
force-pushed
the
unique-binding-names
branch
from
e8d6487 to
852ad20
Compare
petebacondarwin
approved these changes
Mar 24, 2022
Co-authored-by: Pete Bacon Darwin <pete@bacondarwin.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #658