Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slack channel name #85

Open
professor opened this issue Jun 23, 2020 · 4 comments
Open

Slack channel name #85

professor opened this issue Jun 23, 2020 · 4 comments

Comments

@professor
Copy link
Contributor

Slack currently creates a webhook per channel. The API for this concourse resource implies that you can change the slack channel name without changing the webhook. Unfortunately, changing the channel name in yml won't work...

---
jobs:
- name: some-job
  plan:
  - put: slack-alert
    params:
      channel: '#my_channel'

#my_channel needs to be the match the webhook url

@jhunt
Copy link
Contributor

jhunt commented Jun 24, 2020

Yeah, we need to remove the channel param altogether, since they don't do it that way any more.

@jhunt
Copy link
Contributor

jhunt commented Jun 24, 2020

I put in #86 for this. Would you care to take it for a spin?

@professor
Copy link
Contributor Author

@jhunt -- what's the best mechanism for me to test #86? Is there a tag for it?

@jhunt
Copy link
Contributor

jhunt commented Nov 7, 2020

No, but you should be able to build the image off of the branch and push it to DockerHub to test locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants