Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Users Table: Restrict org/space roles and prefix space name with org... depending on depth #2402

Merged
merged 7 commits into from
Jun 20, 2018

Conversation

richard-cox
Copy link
Contributor

Blocked on #2390

Ensure no missleading orgs or spaces are shown are the org/space cf user tables

  • cf level user table - show all orgs + spaces
  • org level user table - show only that org's roles and the org's space roles
  • space level user table - show only that org's roles and only that space's roles

Prefix the org name to the space name for space roles

  • Only do this at the cf level

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…ser tables

- cf level user table - show all orgs + spaces
- org level user table - show only that org's roles and the org's space roles
- space level user table - show only that org's roles and only that space's roles
@cfdreddbot
Copy link

Hey richard-cox!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

@richard-cox richard-cox added the conflicts Merge conflicts on PR label Jun 15, 2018
@richard-cox richard-cox removed the conflicts Merge conflicts on PR label Jun 18, 2018
@codecov
Copy link

codecov bot commented Jun 18, 2018

Codecov Report

Merging #2402 into v2-master will decrease coverage by 0.11%.
The diff coverage is 68.75%.

@@              Coverage Diff              @@
##           v2-master    #2402      +/-   ##
=============================================
- Coverage         71%   70.89%   -0.12%     
=============================================
  Files            585      585              
  Lines          24558    24605      +47     
  Branches        5511     5522      +11     
=============================================
+ Hits           17437    17443       +6     
- Misses          7121     7162      +41

Copy link
Contributor

@nwmac nwmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nwmac nwmac merged commit 1cba9f1 into v2-master Jun 20, 2018
@nwmac nwmac deleted the fix-users-table branch June 20, 2018 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants