Fix issue timing issue resulting in invalid Space Service request #2489
+36
−49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey irfanhabib! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA. |
Codecov Report
@@ Coverage Diff @@
## v2-master #2489 +/- ##
=============================================
- Coverage 70.71% 70.63% -0.08%
=============================================
Files 590 590
Lines 24832 24836 +4
Branches 5605 5609 +4
=============================================
- Hits 17559 17542 -17
- Misses 7273 7294 +21 |
- Ensure the space service page loads succesfuly - Fixed service name on space service page (legacy issue) - Ensure parity in existing get service instance from space action with removed one
richard-cox
approved these changes
Jun 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2468.
Was able to reproduce this issue, and it appeared to be a timing issue.
When creating a service instance: once a CF/Org/Space are selected the user proceeds to the next page. In the next page services available in the space are fetched. If one value (i.e CF) has been updated in the store, but Space hasn't, invalid values propagate in the observable chain.