Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo in key name when accessing log-cache from root endpoint #1251

Open
Lokowandtg opened this issue Dec 3, 2024 · 1 comment · May be fixed by #1252
Open

Typo in key name when accessing log-cache from root endpoint #1251

Lokowandtg opened this issue Dec 3, 2024 · 1 comment · May be fixed by #1252

Comments

@Lokowandtg
Copy link

The root endpoint provides the URL of the log cache in the key "log_cache", but the code accesses it with the key "log-cache", never returning the correct value.
There is a fallback which uses the api-endpoint and replaces any occurrence of "api" with "log-cache". This works in most of the cases, but not if the letters "api" are part of the remaining URL.
@Lokowandtg Lokowandtg linked a pull request Dec 3, 2024 that will close this issue
Open
@Lokowandtg
Copy link
Author

I am not sure what the correct failure behavior should be for the fallback case:
a) replace "api" only if it is right after "https://", at the start of the URL and throw an exception if it is not found there.
b) replace "api" only if it is right after "https://", at the start of the URL and return the unchanged URL if no replacement happens (current behavior).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@Lokowandtg