-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for the PROXY protocol #125
Comments
We have created an issue in Pivotal Tracker to manage this. You can view the current status of your issue at: https://www.pivotaltracker.com/story/show/116601821. |
Hello @Jonty Do you specifically want to send gorouter the source IP for websocket requests? Or are you losing client info for HTTP requests as a result of running your ELB in TCP Mode (because you also want to support websockets)? Are you serving HTTP and websocket requests on the same port on your ELB? Have you considered serving these requests on different ports? The team running Pivotal Web Services (http://run.pivotal.io/) have configured their ELB to listen on ports 80 and 443 in HTTP mode, and port 4443 in TCP mode (in support of websockets). So client info comes through for HTTP requests, but not (I assume, based on your request) for websocket requests. Thank you |
|
#126 was merged |
Gorouter does not support the PROXY protocol meaning that SSL terminators placed in front of it cannot pass on the client IP address.
This is a problem for us because we have an AWS ELB in front of gorouter operating in TCP mode, as ELB in HTTP mode (which would inject
X-Forwarded-For
headers) does not support websockets.A horrid workaround is to colocate something like HAProxy that understands the PROXY protocol and can add an
X-Forwarded-For
header using the address passed via PROXY.The text was updated successfully, but these errors were encountered: