As a Korifi app developer I want to see an error when I try to create a managed service instance of a disabled service plan

[georgethebeatle]

Background

Right now in Korifi we do set service plan visibility on the service plan resource, but the service instance controller does not observe it. This means that the instance will go to failed state and will never be able to recover.

Acceptance

GIVEN I have a plan that is not visible
WHEN I create a service instance for it
THEN tbd

Dev Notes

• What is the behaviour of classic CF when we create an instance of a disabled plan? Can the instance recover or should it be re-created?
• We should error when a user tries to create an instance of a disabled service plan
• Existing instances in an errored state (as described above) should be able to recover once the plan is enabled.
• Ready instances should remain ready when their plan is disabled.
• All checks should happen in the controllers, so that kubectl users can have the experience as api users
• Think about whether is makes sense to spin off a separate story for org visibility or if we should deliver all three visibilities with one story
• For now space visibility is out of scope