You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When implementing managed services support, we decided that we are going to make use of finalizers to ensure that the instance is deprovisioned with the service broker when the managed CFServiceInstance resource is deleted. The finalization logic is only necessary for managed service instances, therefore we decided to set finalizers on managed CFServiceInstances only
However, checking the service instance type within the webhook context requires using the dynamic k8s client and that is not great. Can we instead install finalizer on the every CFServiceInstance (regardless managed or not), and have the instance controller decide whether finalization is needed:
For UPSIs, the controller should simply remove the finalizer
For managed instances, the controller should deprovision the service with the broker (this is what we have as of today)
If we change the finalizer set policy, would that be a problem for existing UPSIs?
If we decide to rename the finalizer (as it is not going to be specific to managed services only anymore), do we care that existing managed instances would become undeletable (unless someone removes the old finalizer manually)? Maybe that would not be an issue as the managed services support is experimental anyway
The text was updated successfully, but these errors were encountered:
Background
When implementing managed services support, we decided that we are going to make use of finalizers to ensure that the instance is deprovisioned with the service broker when the managed
CFServiceInstance
resource is deleted. The finalization logic is only necessary for managed service instances, therefore we decided to set finalizers on managedCFServiceInstances
onlyHowever, checking the service instance type within the webhook context requires using the dynamic k8s client and that is not great. Can we instead install finalizer on the every
CFServiceInstance
(regardless managed or not), and have the instance controller decide whether finalization is needed:Action to take
Always
The text was updated successfully, but these errors were encountered: