Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store environment for LRPs and kpack builds in secrets #925

Closed
danail-branekov opened this issue Apr 7, 2022 · 2 comments
Closed

Store environment for LRPs and kpack builds in secrets #925

danail-branekov opened this issue Apr 7, 2022 · 2 comments

Comments

@danail-branekov
Copy link
Member

danail-branekov commented Apr 7, 2022

This depends on #917

This is to adopt the fix from the issue above in Korifi. We should make sure that we inject environment in LRPs and kpack builds securely over secrets rather than a plain-text key-value pairs.

@danail-branekov danail-branekov changed the title Store secrets for LRPs and kpack builds in secrets Store environment for LRPs and kpack builds in secrets Apr 7, 2022
@gcapizzi
Copy link
Contributor

I think this has already been done - @danail-branekov do you confirm?

@danail-branekov
Copy link
Member Author

Actually, this issue is no longer relevant as we are not using eirini-controller anymore.

Other than that, we do use secrets to store environments already. Closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

2 participants