Skip to content
This repository has been archived by the owner on Dec 3, 2024. It is now read-only.

No guard for DATABASE_URL env var #19

Open
osis opened this issue Jan 16, 2019 · 2 comments
Open

No guard for DATABASE_URL env var #19

osis opened this issue Jan 16, 2019 · 2 comments

Comments

@osis
Copy link
Contributor

osis commented Jan 16, 2019

While setting up a new environment, I noticed I started getting this error...

Test Panicked
  Error 1251: Client does not support authentication protocol requested by server; consider upgrading MariaDB client
  /usr/local/go/src/runtime/panic.go:491

Which was a bit alarming, but I think it's actually the result of not setting this environment variable.

Tracked it down to maybe this part of the source not functioning properly?

Also noticed that the tests don't cover this case. https://github.com/cloudfoundry-incubator/notifications/blob/master/application/environment_test.go#L63

@cf-gitbot
Copy link

We have created an issue in Pivotal Tracker to manage this. Unfortunately, the Pivotal Tracker project is private so you may be unable to view the contents of the story.

The labels on this github issue will be updated when the story is started.

@osis
Copy link
Contributor Author

osis commented Jan 17, 2019

Turns out it was that was surfacing this configuration issue.

mysqljs/mysql#1507 (comment)

The error that you eventually cascades down to...

Test Panicked
  Error 1049: Unknown database 'notifications_test'

still, a "DOCKER_URL not set"-like error would be a nicer experience.

@osis osis added chore and removed chore labels Jan 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants