Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the client_auth_method check #3243

Merged
merged 3 commits into from
Feb 4, 2025
Merged

Conversation

strehle
Copy link
Member

@strehle strehle commented Jan 17, 2025

Ensure for client_credentials that either secret or private_key_jwt is used
If value from claim client_auth_method is none or empty we have to reject token requests

Prevent

uaac client update cf --authorized_grant_types "client_credentials"
uaac token client get cf -t -s ""

Ensure for client_credentials that either secret or private_key_jwt is used
If value from claim client_auth_method is none or empty we have to reject token requests
@strehle strehle requested review from duanemay and fhanik January 17, 2025 18:03
Wanted is bad request
Copy link
Member

@duanemay duanemay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@strehle strehle merged commit e7a9334 into develop Feb 4, 2025
22 checks passed
@strehle strehle deleted the fix/client_credentails_auth_method branch February 4, 2025 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Cleanup UAA Client Secret Setting and Ensure Authentication on Client Credentials Grant Flow
2 participants