Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing data errors with no context #102

Open
bryfox opened this issue Sep 8, 2017 · 0 comments
Open

Missing data errors with no context #102

bryfox opened this issue Sep 8, 2017 · 0 comments

Comments

@bryfox
Copy link

bryfox commented Sep 8, 2017

The data helper is missing an undefined check. If I call data("some.invalid.key.path"), then I get TypeError: Cannot read property 'contents' of undefined. From the stacktrace, I see it's a problem with data, but have no idea about what input is causing the problem.

More useful might be to throw an error that indicates that the data is missing at the given path. If that strictness isn't needed/intended, I could imagine instead logging a warning and continuing, but I don't see any patterns like that used elsewhere in the builder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant