-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should we use the same key for titles/names? #82
Comments
Now that I'm getting deeper into this, I'm noticing this as well. Do we have a preference of one over the other? |
FWIW, I am not aware of a specific reason to differentiate between them. In working to solve cloudfour/drizzle#22, I'm also finding this awkard. In the case of cloudfour/drizzle#22, it would make more sense for them to have the same key. Does this mean changes would need to happen to the https://github.com/cloudfour/drizzle-builder repo? I'm not clear of the separation here. |
@mrgerardorodriguez Looking at the docs for the builder, it says that I believe every instance of That said, I need to see exactly what the builder is doing under the hood to verify how Regarding your partial, what challenges are you facing? I think the partial should be ignorant of these |
You were spot on. :) |
I'm noticing that a little bit of template complexity so far is accounting for pages having titles while patterns have names. I can't remember which ones collections have.
It's not a huge deal, and there may be value in differentiating them. But if not, we may want to consider using the same term for everything for straightforwardness.
@mrgerardorodriguez @erikjung
The text was updated successfully, but these errors were encountered: