Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a few race conditions in
test_waker_threaded()
and adds a timeout to ensure that it doesn’t hang forever if something goes wrong.Some notes:
poll()
and the start of the next loop.reset()
could swallow the last wake.poll()
after the thread finishes. I’m not sure how it gets more events, but when I only checked foris_finished()
when getting a timeout, it sometimes hung forever.Fixes: #19 — test_waker_threaded fails or hangs in Rust 1.70