perf: lazy validators (ME-15925) #606

tsi · 2024-04-08T09:52:34Z

This PR adds a debug mode that will determine the appearance of dev logs and warnings

netlify · 2024-04-08T09:52:49Z

✅ Deploy Preview for cld-video-player ready!

Name	Link
🔨 Latest commit	`e947215`
🔍 Latest deploy log	https://app.netlify.com/sites/cld-video-player/deploys/6615478aef5e340008a0156d
😎 Deploy Preview	https://deploy-preview-606--cld-video-player.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

tsi · 2024-04-08T09:54:42Z

src/plugins/videojs-http-source-selector/components/SourceMenuButton.js

@@ -36,8 +36,7 @@ class SourceMenuButton extends MenuButton {
    }

    // Bind update to qualityLevels changes
-    // Todo: switch to Function.prototype.bind
-    this.player_.qualityLevels().on(['change', 'addqualitylevel', 'removequalitylevel'], videojs.bind(this, this.update));
+    this.player_.qualityLevels().on(['change', 'addqualitylevel', 'removequalitylevel'], this.update.bind(this));


Suppress a deprecation console warning regarding videojs.bind

@tsi is it riksy? because our assumption was that this PR would be focusing on very minimal risk stuff.

I don't think so, but let's wait with it till next release

ehab-cl · 2024-04-08T10:57:08Z

src/plugins/videojs-http-source-selector/components/SourceMenuButton.js

@@ -36,8 +36,7 @@ class SourceMenuButton extends MenuButton {
    }

    // Bind update to qualityLevels changes
-    // Todo: switch to Function.prototype.bind
-    this.player_.qualityLevels().on(['change', 'addqualitylevel', 'removequalitylevel'], videojs.bind(this, this.update));
+    this.player_.qualityLevels().on(['change', 'addqualitylevel', 'removequalitylevel'], this.update.bind(this));


@tsi is it riksy? because our assumption was that this PR would be focusing on very minimal risk stuff.

ehab-cl · 2024-04-08T14:03:51Z

src/video-player.js

+    if (this.playerOptions.debug) {
+      isValidPlayerConfig(this.options).then((valid) => {
+        if (!valid) {
+          this._isPlayerConfigValid = valid;


why not set it directly to false?

ehab-cl · 2024-04-08T14:05:34Z

src/video-player.js

@@ -390,7 +390,7 @@ class VideoPlayer extends Utils.mixin(Eventable) {
  _initAnalytics() {
    const analyticsOpts = this.playerOptions.analytics;

-    if (!window.ga && analyticsOpts) {
+    if (!window.ga && analyticsOpts && this.playerOptions.debug) {


For later i think it is better to create an abstract that wraps the console.error statement and considers the debug mode.

This reverts commit d435ca5.

BREAKING CHANGE: player core is the default ES export chore: un-publish sourcemaps perf: cleanup codec logic (#590) chore: update videojs-contrib-dash perf: update dependencies (#594) chore: update httpSourceSelector plugin perf: utils refactor & cleanup (#595) chore: simplify eslintrc (#604) build: add default profiles json files to build output in es version (#603) perf: debug mode & lazy validators (ME-15925) (#606) fix: withCredentials (ME-16117) (#607) fix: esm example pages (ME-16168) (#613) chore: cleanup deprecated snyk

* chore(deps-dev): bump undici from 5.28.2 to 5.28.3 (#559) Bumps [undici](https://github.com/nodejs/undici) from 5.28.2 to 5.28.3. - [Release notes](https://github.com/nodejs/undici/releases) - [Commits](nodejs/undici@v5.28.2...v5.28.3) --- updated-dependencies: - dependency-name: undici dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix: av1 support (#557) * chore(edge): release 1.10.7-edge.0 (#561) * ME-6152-type-definitions (#560) * fix: type definitions * fix: type definitions * chore: remove jsdocs * fix: type definitions * fix: type definitions * fix: type definitions * chore: remove jsdocs * chore(edge): release 1.10.7-edge.1 (#562) * fix: types exports (#565) * chore(edge): release 1.10.7-edge.2 (#566) * feat: kareoke style subtitles (#563) * feat: karaoke style subtitles * fix: types exports * feat: kareoke style subtitles * feat: kareoke style subtitles * feat: kareoke style subtitles * chore: add example page * chore(edge): release 1.10.7-edge.3 (#567) * chore(edge): release 1.10.7-edge.3 * Update CHANGELOG.md --------- Co-authored-by: Tsachi Shlidor <tsachi.shlidor@cloudinary.com> * fix: allowUsageReport (#569) * chore(edge): release 1.10.7-edge.4 (#570) * fix: mimetypes (#572) * fix: mimetypes * fix: mimetypes * fix: mimetypes * fix: poster image for raw URLs (#573) * chore(edge): release 1.10.7-edge.5 (#574) * chore: example pages (#575) * chore: example pages * chore: example pages * chore: example pages * CI: Create update_master.yml * CI: Update update_master.yml * Update update_master.yml * CI: Update update_master.yml * CI: Update update_master.yml * CI: Update update_master.yml * CI: Update update_master.yml * ci: Update update_master.yml * ci: Update update_master.yml * ci: Update update_master.yml * chore: update update_master.yml * chore(deps-dev): bump undici from 5.28.2 to 5.28.3 (#559) * fix: av1 support (#557) * chore(edge): release 1.10.7-edge.0 (#561) * ME-6152-type-definitions (#560) * fix: type definitions * fix: type definitions * chore: remove jsdocs * fix: type definitions * fix: type definitions * fix: type definitions * chore: remove jsdocs * chore(edge): release 1.10.7-edge.1 (#562) * fix: types exports (#565) * chore(edge): release 1.10.7-edge.2 (#566) * feat: kareoke style subtitles (#563) * feat: karaoke style subtitles * fix: types exports * feat: kareoke style subtitles * feat: kareoke style subtitles * feat: kareoke style subtitles * chore: add example page * chore(edge): release 1.10.7-edge.3 (#567) * chore(edge): release 1.10.7-edge.3 * Update CHANGELOG.md * fix: allowUsageReport (#569) * chore(edge): release 1.10.7-edge.4 (#570) * fix: mimetypes (#572) * fix: mimetypes * fix: mimetypes * fix: mimetypes * fix: poster image for raw URLs (#573) * chore(edge): release 1.10.7-edge.5 (#574) * chore: example pages (#575) * chore: example pages * chore: example pages * chore: example pages * CI: Create update_master.yml * CI: Update update_master.yml * Update update_master.yml * CI: Update update_master.yml * CI: Update update_master.yml * CI: Update update_master.yml * CI: Update update_master.yml * ci: Update update_master.yml * ci: Update update_master.yml * ci: Update update_master.yml * Update update_master.yml * Update update_master.yml * fix: styled subtitles browser compatibility (#576) * fix: styled subtitles browser compatibility * chore: unlazy styled subtitles * chore(edge): release 1.11.1-edge.0 (#583) * perf!: default export to be base videoPlayer (#588) * perf!: default export to be base videoPlayer BREAKING CHANGE: the default ES import is now only the player core plugins need to be explicitly imported * chore: ignore sourcemaps * chore(edge): release 2.0.0-edge.1 (#589) * perf: cleanup codec logic (#590) * perf: cleanup codec logic chore: update videojs-contrib-dash * chore: cleanup * chore: hasCodec * chore: updated exports * perf: cleanup codec logic chore: update videojs-contrib-dash * chore: cleanup * chore: updated exports * chore: exports * chore: exports * perf: update dependencies (#594) * chore: update dependencies * chore: bundlewatch * perf: update dependencies * perf: update dependencies * chore: update dependencies * chore: update eslint * chore: update httpSourceSelector plugin * chore(edge): release 2.0.0-edge.2 (#593) * perf: utils refactor & cleanup (#595) * perf: utils refactor (array, assign, playlist utils) * perf: utils refactor (cloudinary, css-prefix, dom, find) * perf: utils refactor (cloudinary, css-prefix, dom, find) * perf: utils refactor (groupBy, matches) * perf: utils refactor (find, omit, get, object, positioning, tests, playButton) * chore: bundlesize * perf: utils refactor (webpack loaders) * perf: utils refactor (startsWith, camelize) * perf: utils refactor (throttle, types) * perf: utils refactor (isObject) * chore: cleanup * perf: utils refactor (hasCodec) * chore: export * chore(edge): release 2.0.0-edge.3 (#597) * fix: isPlainObject (#598) * chore(edge): release 2.0.0-edge.4 (#599) * fix: esm examples * fix: esm examples * fix: recommendations * chore: updates * chore: pr fixes * chore(edge): release 2.0.0-edge.5 (#601) * fix: eslintrc (#604) * build: add default profiles json files to build output in es version (#603) * build: add default profiles json files to build output in es version * build: simplify profiles path * perf: debug mode & lazy validators (ME-15925) (#606) * perf: lazy validators * chore: cleanup * chore: cleanup * chore: pr comments * Revert "chore: pr comments" This reverts commit d435ca5. * chore: pr comments * chore: pr comments * chore(edge): release 2.0.0-edge.6 (#605) * fix: withCredentials (ME-16117) (#607) * fix: withCredentials * fix: withCredentials in playerConfig as documented * chore(edge): release 2.0.0-edge.7 (#608) * fix: esm examples (#609) * chore(edge): release 2.0.0-edge.8 (#610) * fix: debug mode analytics (#611) * fix: esm example pages (ME-16168) (#613) * fix: esm example pages * fix: esm examples preview * fix: deprecated snyk * fix: esm examples * chore(edge): release 2.0.0-edge.9 (#614) * Update update_master.yml * Update update_master.yml * Update update_master.yml * fix: undeprecate Cloudinary.new() (ONCALL-3380) (#619) * fix: undeprecate Cloudinary.new() * chore: add an embedded player example * ci: netlify ignore unchanged * chore: example should default to edge * chore(edge): release 2.0.1-edge.0 (#620) --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: cloudinary-jenkins <jenkins@cloudinary.com> Co-authored-by: jakub-roch <70572646+jakub-roch@users.noreply.github.com>

perf: lazy validators

eb6d654

tsi requested review from jakub-roch and ehab-cl April 8, 2024 09:52

tsi self-assigned this Apr 8, 2024

tsi requested a review from a team as a code owner April 8, 2024 09:52

tsi commented Apr 8, 2024

View reviewed changes

tsi changed the title ~~perf: lazy validators~~ perf: lazy validators (ME-15925) Apr 8, 2024

tsi added 2 commits April 8, 2024 13:40

chore: cleanup

0760c5e

chore: cleanup

f8a11a4

ehab-cl approved these changes Apr 8, 2024

View reviewed changes

tsi added 5 commits April 9, 2024 11:21

Merge branch 'edge' into ME-15925-debug-mode

23ad3d9

chore: pr comments

d435ca5

Revert "chore: pr comments"

6e9e1a8

This reverts commit d435ca5.

chore: pr comments

87c3b9f

chore: pr comments

e947215

tsi merged commit 74ffd93 into edge Apr 9, 2024
5 checks passed

tsi deleted the ME-15925-debug-mode branch April 9, 2024 14:07

cloudinary-jenkins mentioned this pull request Apr 9, 2024

chore(edge): release 2.0.0-edge.6 #605

Merged

cloudinary-jenkins mentioned this pull request Apr 14, 2024

chore(master): release 2.0.0 #618

Merged

This was referenced Jun 10, 2024

chore(master): release 3.0.0-edge.1 #653

Closed

chore(edge): release 2.0.3-edge.0 #654

Closed

chore(edge): release 2.0.3-edge.0 #655

Closed

chore(edge): release 2.0.4-edge.0 #656

Merged

chore(master): release 2.0.3 #657

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

perf: lazy validators (ME-15925) #606

perf: lazy validators (ME-15925) #606

tsi commented Apr 8, 2024

netlify bot commented Apr 8, 2024 •

edited

Loading

tsi Apr 8, 2024

ehab-cl Apr 8, 2024

tsi Apr 9, 2024

ehab-cl Apr 8, 2024

ehab-cl Apr 8, 2024

ehab-cl Apr 8, 2024

perf: lazy validators (ME-15925) #606

perf: lazy validators (ME-15925) #606

Conversation

tsi commented Apr 8, 2024

netlify bot commented Apr 8, 2024 • edited Loading

✅ Deploy Preview for cld-video-player ready!

tsi Apr 8, 2024

Choose a reason for hiding this comment

ehab-cl Apr 8, 2024

Choose a reason for hiding this comment

tsi Apr 9, 2024

Choose a reason for hiding this comment

ehab-cl Apr 8, 2024

Choose a reason for hiding this comment

ehab-cl Apr 8, 2024

Choose a reason for hiding this comment

ehab-cl Apr 8, 2024

Choose a reason for hiding this comment

netlify bot commented Apr 8, 2024 •

edited

Loading