Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: seek-thumbs positioning #766

Merged
merged 1 commit into from
Dec 18, 2024
Merged

fix: seek-thumbs positioning #766

merged 1 commit into from
Dec 18, 2024

Conversation

tsi
Copy link
Collaborator

@tsi tsi commented Dec 17, 2024

Fixes a regression caused by this change in videojs.

Now, our hacky work-around is not needed anymore, and we can simply configure the player to behave nicely on mobile.

@tsi tsi requested review from jakub-roch and ehab-cl December 17, 2024 16:24
@tsi tsi self-assigned this Dec 17, 2024
@tsi tsi requested a review from a team as a code owner December 17, 2024 16:24
Copy link

netlify bot commented Dec 17, 2024

Deploy Preview for cld-video-player ready!

Name Link
🔨 Latest commit 15fdc50
🔍 Latest deploy log https://app.netlify.com/sites/cld-video-player/deploys/6761a5ce86588c0008935540
😎 Deploy Preview https://deploy-preview-766--cld-video-player.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 17, 2024

Deploy Preview for cld-vp-esm-pages ready!

Name Link
🔨 Latest commit 15fdc50
🔍 Latest deploy log https://app.netlify.com/sites/cld-vp-esm-pages/deploys/6761a5ce21c2c20008e7f033
😎 Deploy Preview https://deploy-preview-766--cld-vp-esm-pages.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@ehab-cl ehab-cl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪

@tsi tsi merged commit 5a16f74 into edge Dec 18, 2024
10 checks passed
@tsi tsi deleted the ME-18566-seek-thumbs-position branch December 18, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants