Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix callback path. #138

Closed
wants to merge 1 commit into from
Closed

Fix callback path. #138

wants to merge 1 commit into from

Conversation

ombr
Copy link

@ombr ombr commented Jan 29, 2015

Just by reading there is a problem here... + I spend like 20 minutes because the callback is named callback_cors in the options...

@nadavs nadavs assigned nadavs and tocker and unassigned nadavs Feb 5, 2015
@tocker
Copy link
Contributor

tocker commented Feb 16, 2015

Hi @ombr,

Thanks for catching this up!
Unfortunately your fix is incomplete as it ignores the callback_url being built inside the if block.
Can you please modify your code to refer to that scenario?

Amir

@tocker
Copy link
Contributor

tocker commented Mar 19, 2015

@ombr thanks for the PR!
I've fixed the bug and it will be included in the next release.

-- tocker

@tocker tocker closed this Mar 19, 2015
tocker added a commit that referenced this pull request Mar 22, 2015
  * Added Video Support
    * `cl_video_tag` creates an HTML video tag with optionally inner `source` tags
    * `cl_video_path` provides a url to the video resource
    * `cl_video_thumbnail_tag` creates an `img` tag with a video thumbnail and
    * `cl_video_thumbnail_path` provides a url to the video resource's thumbnail
  * Added `:zoom` transformation parameter
  * Applied Pull Requests:
    * Fix image closing tags #144
    * Fix callback path. #138
  * Update Cloudinary's jQuery plugin to v1.0.22.
  * Update .gitignore file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants