Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: CI #308

Merged
merged 2 commits into from
Dec 1, 2023
Merged

fix: CI #308

merged 2 commits into from
Dec 1, 2023

Conversation

erikmom
Copy link
Contributor

@erikmom erikmom commented Nov 30, 2023

No description provided.

@erikmom
Copy link
Contributor Author

erikmom commented Nov 30, 2023

@maxime1992 With help of a colleague, I got the Github action to work on my own fork (See https://github.com/erikmom/ngx-sub-form/actions/runs/7048769520).

ubuntu-20-10 does not seem to be available as runner on github. Changed it to ubuntu-latest and then it uses ubuntu20-4.

Also noticed now that I again had some issues with line endings on changed files. This commit also fixes that

@maxime1992
Copy link
Contributor

Brilliant, thanks a lot for digging into that.

The only thing would be, can you fix the version to use 20.04? That's what it was doing before I did attempt to change it as I thought it was needed to use 20.10. 7957087

But if it's not, I'd still rather have the exact version, it can save some troubles while debugging.

@erikmom
Copy link
Contributor Author

erikmom commented Nov 30, 2023

Updated. Will it pick up the correct verion number? Or at least something v10+ ?

@maxime1992
Copy link
Contributor

Yes it should :) Thanks for the PR!

@maxime1992 maxime1992 merged commit bc97dd8 into cloudnc:master Dec 1, 2023
Copy link

github-actions bot commented Dec 1, 2023

🎉 This PR is included in version 10.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@erikmom erikmom deleted the fix-ci branch May 30, 2024 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants