Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Documentation for Build-time and Runtime Feature Flags #768

Open
korenyoni opened this issue Jan 30, 2022 · 3 comments
Open

Improve Documentation for Build-time and Runtime Feature Flags #768

korenyoni opened this issue Jan 30, 2022 · 3 comments
Labels
documentation Improvements or additions to documentation

Comments

@korenyoni
Copy link
Member

Have a question? Please checkout our Slack Community or visit our Slack Archive.

Slack Community

Describe the Feature

There is insufficient documentation for build-time and runtime feature flags.

Use Case

Dockerfile Feature Flags

  • e.g. DIRENV_ENABLED

Geodesic Wrapper Script Feature Flags

  • e.g. GEODESIC_MAC_FORWARD_SOCKET

Describe Ideal Solution

Add an easily-maintainable page (perhaps with two tables — one for build-time feature flags and one for runtime feature falgs) in docs/. Probably, it's going to be easier to maintain if doesn't intend to be entirely comprehensive. I.e. a "Commonly-used feature flags" page is probably ideal.

Alternatives Considered

Don't document feature flags at all? i.e. let the code speak for itself?

Additional Context

@drmikecrowe
Copy link

I would suggest arrange such that the community can contribute. For example, I've spent a bit of time in geodesic and would like a section to document some things that n00bs might find interesting: Adding how to customize the wrapper script for install, node via nvm to geodesic as a tool, use starship for the prompt instead of the default prompt, etc.

Also:

See, for example "New options for customizing command line prompt appearance" in the Release Notes for v0.149.0

This example should be part of this customization documentation, and should simply be referenced in the release notes. Scrape the release notes for nuggets like this that can become part of this section

@Nuru
Copy link
Contributor

Nuru commented Jul 4, 2022

  • Make forwarding ssh-agent socket the default, document how to disable it.
  • Add the ability to configure wrapper preferences via a config file (~/.geodesic/env does not affect the wrapper)

@Gowiem
Copy link
Member

Gowiem commented Sep 15, 2022

@korenyoni @Nuru just wanted to voice my support for this issue... Geodesic could obviously use as much documentation as it can get considering all the great work you folks have built into it. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

4 participants