Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incorrect log-group role principal #35

Open
dougbergh opened this issue Jan 29, 2024 · 0 comments
Open

incorrect log-group role principal #35

dougbergh opened this issue Jan 29, 2024 · 0 comments
Labels
bug 🐛 An issue with the system

Comments

@dougbergh
Copy link

Describe the Bug

The module creates a log-group role with principal service "ec2.amazonaws.com". The api-gateway is then unable to be created.

The principal service should be "apigateway.amazonaws.com"

Expected Behavior

The log group role should be created with principal service "apigateway.amazonaws.com"

Steps to Reproduce

create an api-gateway in AWS using the module

Screenshots

No response

Environment

No response

Additional Context

In a SweetOps exchange with Andriy Knysh, he suggested the following:

this is an omission here: https://github.com/cloudposse/terraform-aws-api-gateway/blob/main/main.tf#L28. The variable principals needs to be added since the https://github.com/cloudposse/terraform-aws-cloudwatch-logs/blob/main/variables.tf  module supports it. Then you could override principals in your code when instantiating the https://github.com/cloudposse/terraform-aws-api-gateway  module

@dougbergh dougbergh added the bug 🐛 An issue with the system label Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 An issue with the system
Projects
None yet
Development

No branches or pull requests

1 participant