fix: Security Group module update, SSH Key as optional #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![bridgecrew[bot]](https://avatars.githubusercontent.com/in/52968?s=60&v=4){kind=small}
milldr
changed the title
|
/test all |
|
/test all |
|
/test all |
|
/test all |
|
/test all |
|
/test all |
|
/test all |
nitrocode
reviewed
Oct 22, 2021
nitrocode
reviewed
Oct 22, 2021
milldr
requested review from
Makeshift and
adamcrews
and removed request for
a team
nitrocode
reviewed
Oct 25, 2021
| @@ -1,5 +1,5 @@ | |||
| terraform { | |||
| required_version = ">= 0.13" | |||
| required_version = ">= 0.14" | |||
|
|
|||
| required_providers { | |||
| aws = { | |||
nitrocode
reviewed
Oct 25, 2021
| variable "ssh_key_enabled" { | ||
| type = bool | ||
| description = "If false, no SSH key will be created or associated with the instance(s)." | ||
| default = true |
There was a problem hiding this comment.
This should be false so ssm is relied upon instead of ssh keys
Nuru
requested changes
Oct 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
why
references