Incorrect defaults for ecs_alarms_cpu_utilization_high

[stormmore]

Any of the action variables should default to [""] otherwise even if you set alb_groupd_alarms_enabled = false you will get errors about empty list of strings:

terraform-aws-ecs-web-app/variables.tf

Lines 307 to 407 in 9d86839

	variable "ecs_alarms_cpu_utilization_high_alarm_actions" {
	type = list(string)
	description = "A list of ARNs (i.e. SNS Topic ARN) to notify on CPU Utilization High Alarm action"
	default = []
	}
	variable "ecs_alarms_cpu_utilization_high_ok_actions" {
	type = list(string)
	description = "A list of ARNs (i.e. SNS Topic ARN) to notify on CPU Utilization High OK action"
	default = []
	}
	variable "ecs_alarms_cpu_utilization_low_threshold" {
	type = number
	description = "The minimum percentage of CPU utilization average"
	default = 20
	}
	variable "ecs_alarms_cpu_utilization_low_evaluation_periods" {
	type = number
	description = "Number of periods to evaluate for the alarm"
	default = 1
	}
	variable "ecs_alarms_cpu_utilization_low_period" {
	type = number
	description = "Duration in seconds to evaluate for the alarm"
	default = 300
	}
	variable "ecs_alarms_cpu_utilization_low_alarm_actions" {
	type = list(string)
	description = "A list of ARNs (i.e. SNS Topic ARN) to notify on CPU Utilization Low Alarm action"
	default = []
	}
	variable "ecs_alarms_cpu_utilization_low_ok_actions" {
	type = list(string)
	description = "A list of ARNs (i.e. SNS Topic ARN) to notify on CPU Utilization Low OK action"
	default = []
	}
	variable "ecs_alarms_memory_utilization_high_threshold" {
	type = number
	description = "The maximum percentage of Memory utilization average"
	default = 80
	}
	variable "ecs_alarms_memory_utilization_high_evaluation_periods" {
	type = number
	description = "Number of periods to evaluate for the alarm"
	default = 1
	}
	variable "ecs_alarms_memory_utilization_high_period" {
	type = number
	description = "Duration in seconds to evaluate for the alarm"
	default = 300
	}
	variable "ecs_alarms_memory_utilization_high_alarm_actions" {
	type = list(string)
	description = "A list of ARNs (i.e. SNS Topic ARN) to notify on Memory Utilization High Alarm action"
	default = []
	}
	variable "ecs_alarms_memory_utilization_high_ok_actions" {
	type = list(string)
	description = "A list of ARNs (i.e. SNS Topic ARN) to notify on Memory Utilization High OK action"
	default = []
	}
	variable "ecs_alarms_memory_utilization_low_threshold" {
	type = number
	description = "The minimum percentage of Memory utilization average"
	default = 20
	}
	variable "ecs_alarms_memory_utilization_low_evaluation_periods" {
	type = number
	description = "Number of periods to evaluate for the alarm"
	default = 1
	}
	variable "ecs_alarms_memory_utilization_low_period" {
	type = number
	description = "Duration in seconds to evaluate for the alarm"
	default = 300
	}
	variable "ecs_alarms_memory_utilization_low_alarm_actions" {
	type = list(string)
	description = "A list of ARNs (i.e. SNS Topic ARN) to notify on Memory Utilization Low Alarm action"
	default = []
	}
	variable "ecs_alarms_memory_utilization_low_ok_actions" {
	type = list(string)
	description = "A list of ARNs (i.e. SNS Topic ARN) to notify on Memory Utilization Low OK action"
	default = []
	}

Sorry don't have time right now to fix, test and pr.

[jamengual]

Out tests are passing so I do not think we are experiencing the same issue, have you looked at the new updates? @stormmore