Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disk encryption settings should not refer to launch template #64

Closed
Nuru opened this issue Mar 18, 2021 · 0 comments · Fixed by #84
Closed

Disk encryption settings should not refer to launch template #64

Nuru opened this issue Mar 18, 2021 · 0 comments · Fixed by #84

Comments

@Nuru
Copy link
Contributor

Nuru commented Mar 18, 2021

The variables launch_template_disk_encryption_enabled and launch_template_disk_encryption_kms_key_id are poorly named. The fact that these settings affect the launch template is an implementation detail and should not be reflected in the names.

Please rename them

  • launch_template_disk_encryption_enabled -> disk_encryption_enabled
  • launch_template_disk_encryption_kms_key_id -> disk_encryption_kms_key_id

Notes

  1. Backward compatibility can be maintained by leaving the existing variables in place but changing the defaults to null, and giving them priority when they are non-null
  2. Because of Terraform Module Registry incorrectly shows Inputs as required if default = null hashicorp/terraform#21417, variables with defaults of null are listed as required, so this change should probably wait until that bug is fixed, otherwise the documentation will show the strange result that these deprecated variables are required inputs
@Nuru Nuru mentioned this issue Aug 29, 2021
@Nuru Nuru closed this as completed in #84 Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant