Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dynamic block for log_publishing_options #103

Conversation

JoostSaanen
Copy link

what

Module doesn't work with older ES versions (tested with 1.5 and 2.3)
log_publishing_options is not supported in older versions
Error creating ElasticSearch domain: InvalidTypeException: Application Logs option cannot be specified for ElasticSearch version : 1.5 & 2.3

references

@nitrocode
Copy link
Member

@JoostSaanen could you fix the auto format issues. Normally the bot user would be able to do this but because the fork doesnt have give the cloudpossebot access, it needs to be done manually. I believe you can do it using

make init && make readme

@nitrocode
Copy link
Member

/test all

@Gowiem
Copy link
Member

Gowiem commented Dec 14, 2021

@JoostSaanen please @nitrocode's comment regarding rebuilding the readme. We'll need that to be done to move this PR forward. Thank you!

@JoostSaanen
Copy link
Author

Ouch, missed this one. I'll have a look

@goruha
Copy link
Member

goruha commented Feb 16, 2023

/test all

@goruha
Copy link
Member

goruha commented Feb 18, 2023

@JoostSaanen Could you pls rebase the lastest changes from the master branch?
There are a few fixes for tests.

Thanks.

@hans-d hans-d added wip Work in Progress: Not ready for final review or merge stale This PR has gone stale and removed wip Work in Progress: Not ready for final review or merge labels Mar 8, 2024
Copy link

mergify bot commented Mar 8, 2024

This pull request is now in conflict. Could you fix it @JoostSaanen? 🙏

@mergify mergify bot added the conflict This PR has conflicts label Mar 9, 2024
@mergify mergify bot closed this Mar 9, 2024
Copy link

mergify bot commented Mar 9, 2024

This PR has been closed due to inactivity and merge conflicts.
Please resolve the conflicts and reopen if necessary.

Copy link

mergify bot commented Mar 9, 2024

Thanks @JoostSaanen for creating this pull request!

A maintainer will review your changes shortly. Please don't be discouraged if it takes a while.

While you wait, make sure to review our contributor guidelines.

Tip

Need help or want to ask for a PR review to be expedited?

Join us on Slack in the #pr-reviews channel.

@mergify mergify bot removed the conflict This PR has conflicts label Mar 9, 2024
@mergify mergify bot removed the stale This PR has gone stale label Mar 16, 2024
@sepulworld
Copy link

@cloudposse-mergebot reopen please. this is an issue for me. This fix works

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants