-
-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dynamic block for log_publishing_options #103
Add dynamic block for log_publishing_options #103
Conversation
@JoostSaanen could you fix the auto format issues. Normally the bot user would be able to do this but because the fork doesnt have give the cloudpossebot access, it needs to be done manually. I believe you can do it using
|
/test all |
@JoostSaanen please @nitrocode's comment regarding rebuilding the readme. We'll need that to be done to move this PR forward. Thank you! |
Ouch, missed this one. I'll have a look |
/test all |
@JoostSaanen Could you pls rebase the lastest changes from the master branch? Thanks. |
This pull request is now in conflict. Could you fix it @JoostSaanen? 🙏 |
This PR has been closed due to inactivity and merge conflicts. |
Thanks @JoostSaanen for creating this pull request! A maintainer will review your changes shortly. Please don't be discouraged if it takes a while. While you wait, make sure to review our contributor guidelines. Tip Need help or want to ask for a PR review to be expedited?Join us on Slack in the |
@cloudposse-mergebot reopen please. this is an issue for me. This fix works |
what
Module doesn't work with older ES versions (tested with 1.5 and 2.3)
log_publishing_options is not supported in older versions
Error creating ElasticSearch domain: InvalidTypeException: Application Logs option cannot be specified for ElasticSearch version : 1.5 & 2.3
references