Added startup_script_s3_path and startup_script_s3_object_version arguments.

[oddity-lapada]

• Added startup_script_s3_path and startup_script_s3_object_version arguments to the module to be able use these options from aws_mwaa_environment terraform resource.

[dudymas]

/terratest

[dudymas]

/test all

looks like tests need some updates

[aknysh]

@oddity-lapada thank you for the PR.

There are some issues with the examples and tests, see https://github.com/cloudposse/actions/actions/runs/6435396641/job/17476575403.

To fix the error Unsupported argument, please update the vpc and subnets modules in all the examples (https://github.com/cloudposse/terraform-aws-mwaa/blob/main/examples/minimal/main.tf and https://github.com/cloudposse/terraform-aws-mwaa/blob/main/examples/complete/main.tf) to the latest versions, similar to https://github.com/cloudposse/terraform-aws-rds-cluster/blob/main/examples/complete/main.tf

After that, please run the following commands from the root of the repo and commit the changes:

make init
make github/init
make readme

Thank you

[aknysh]

/test all

[aknysh]

@oddity-lapada thanks for the changes, please address a few more issues.

https://github.com/cloudposse/actions/actions/runs/6487216665/job/17617028387

In the examples, please not only update the module versions, but the module attributes as well, in both the vpc and subnets module.

Please see this as an example.
https://github.com/cloudposse/terraform-aws-rds-cluster/blob/main/examples/complete/main.tf

[aknysh]

please see comments

[DustyShap]

@oddity-lapada any updates to these changes? Currently, not having the startup script is a blocker for us to deploy Airflow using the module.

[hans-d]

@oddity-lapada Hi, can you update the pr so that it passes the tests? otherwise, it is likely to be closed due to staleness.

[mergify]

This pull request now has conflicts. Could you fix it @oddity-lapada? 🙏

[mergify]

This PR has been closed due to inactivity and merge conflicts.
Please resolve the conflicts and reopen if necessary.

[mergify]

Thanks @oddity-lapada for creating this pull request!

A maintainer will review your changes shortly. Please don't be discouraged if it takes a while.

While you wait, make sure to review our contributor guidelines.

Tip

Need help or want to ask for a PR review to be expedited?

Join us on Slack in the #pr-reviews channel.

[mergify]

Important

Cloud Posse Engineering Team Review Required

This pull request modifies files that require Cloud Posse's review. Please be patient, and a core maintainer will review your changes.

To expedite this process, reach out to us on Slack in the #pr-reviews channel.