This repository has been archived by the owner on Aug 16, 2022. It is now read-only.
fix: Explicitly Ignore EC2 Classic EIPs #1055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbernays
requested review from
irmatov,
shimonp21 and
zagronitay
and removed request for
a team
|
Is there a way to filter it on the describe api ? |
Great suggestion! |
zagronitay
approved these changes
Jun 14, 2022
disq
approved these changes
Jun 14, 2022
kodiakhq bot
pushed a commit
that referenced
this pull request
Jun 15, 2022
🤖 I have created a release *beep* *boop* --- ## [0.12.11](v0.12.10...v0.12.11) (2022-06-14) ### Bug Fixes * **deps:** Update module github.com/cloudquery/cq-provider-sdk to v0.11.1 ([#1053](#1053)) ([a48cf77](a48cf77)) * Explicitly Ignore EC2 Classic EIPs ([#1055](#1055)) ([28feadf](28feadf)) * Possible use of a wrong region in s3 buckets. ([#1052](#1052)) ([e54b46a](e54b46a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
7 tasks
erezrokah
pushed a commit
to cloudquery/cloudquery
that referenced
this pull request
Aug 14, 2022
🤖 I have created a release *beep* *boop* --- ## [0.12.11](cloudquery/cq-provider-aws@v0.12.10...v0.12.11) (2022-06-14) ### Bug Fixes * **deps:** Update module github.com/cloudquery/cq-provider-sdk to v0.11.1 ([#1053](cloudquery/cq-provider-aws#1053)) ([a48cf77](cloudquery/cq-provider-aws@a48cf77)) * Explicitly Ignore EC2 Classic EIPs ([#1055](cloudquery/cq-provider-aws#1055)) ([28feadf](cloudquery/cq-provider-aws@28feadf)) * Possible use of a wrong region in s3 buckets. ([#1052](cloudquery/cq-provider-aws#1052)) ([e54b46a](cloudquery/cq-provider-aws@e54b46a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 Thank you for making CloudQuery awesome by submitting a PR 🎉
Summary
EC2 Classic is being turned off in August. It was deprecated last year and was disabled by default 10 years ago. CQ has never fully supported EC2 classic and we will not be adding support for it now
Use the following steps to ensure your PR is ready to be reviewed
go fmtto format your code 🖊golangci-lint run🚨 (install golangci-lint here)go run ./docs/docs.goand committing the changes 📃