Skip to content
This repository has been archived by the owner on Aug 16, 2022. It is now read-only.

feat: Add image deprecation_time #1099

Merged
merged 2 commits into from
Jun 27, 2022
Merged

feat: Add image deprecation_time #1099

merged 2 commits into from
Jun 27, 2022

Conversation

nndegz
Copy link
Contributor

@nndegz nndegz commented Jun 23, 2022 •
edited
Loading

Summary

Use the following steps to ensure your PR is ready to be reviewed

  • Read the contribution guidelines 🧑‍🎓
  • Run go fmt to format your code 🖊
  • Lint your changes via golangci-lint run 🚨 (install golangci-lint here)
  • Update or add tests. Learn more about testing here 🧪
  • Update the docs by running go run ./docs/docs.go and committing the changes 📃
  • If adding a new resource, add relevant Terraform files in a separate PR 📂
  • Ensure the status checks below are successful ✅

@nndegz nndegz requested a review from a team as a code owner June 23, 2022 21:04
@nndegz nndegz requested review from disq and removed request for a team June 23, 2022 21:04
@nndegz nndegz changed the title feat: add image deprecation_time feat: Add image deprecation_time Jun 23, 2022
@erezrokah
Copy link
Member

/test sha=1bc58ba8bab8c0b055ebfd4e7d289fbe7e9f16ec

@erezrokah
Copy link
Member

/test sha=9a48a7b7787465930a9f2454e51692bc0ed25228

erezrokah
erezrokah previously requested changes Jun 26, 2022
View reviewed changes
Copy link
Member

@erezrokah erezrokah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @nndegz 🚀 I added another commit to address the test failure, but will need your help to verify (see comment)

resources/services/ec2/images_mock_test.go Show resolved Hide resolved
@bbernays bbernays requested a review from erezrokah June 27, 2022 18:11
@bbernays bbernays dismissed erezrokah’s stale review June 27, 2022 18:12

Changes were approved

@bbernays bbernays merged commit 55762fd into cloudquery:main Jun 27, 2022
@cq-bot cq-bot mentioned this pull request Jun 27, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bbernays bbernays bbernays approved these changes

@disq disq Awaiting requested review from disq disq is a code owner automatically assigned from cloudquery/cloudquery-opensource

@erezrokah erezrokah Awaiting requested review from erezrokah

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nndegz @erezrokah @bbernays